Skip to content

[build-tools] pass metrics CORS origin to serve-sim#3990

Draft
gwdp wants to merge 1 commit into
mainfrom
gwdp/serve-sim-metrics-cors
Draft

[build-tools] pass metrics CORS origin to serve-sim#3990
gwdp wants to merge 1 commit into
mainfrom
gwdp/serve-sim-metrics-cors

Conversation

@gwdp

@gwdp gwdp commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Why

so the expo.dev dashboard can read serve-sim's live /metrics stream cross-origin.

How

reads EAS_SIMULATOR_METRICS_CORS_ORIGIN from the worker env and passes it to serve-sim as --metrics-cors-origin when launching the tunnel. optional (unset = no cross-origin reads), and a comma-separated value becomes one flag per origin (prod + staging).

Test Plan

CI passes. unit tests cover the env getter and the arg builder.

gwdp commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@gwdp gwdp force-pushed the gwdp/serve-sim-metrics-cors branch from 54257fd to 1230799 Compare July 10, 2026 05:39
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.80%. Comparing base (cc42fdc) to head (1230799).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ld-tools/src/steps/utils/remoteDeviceRunSession.ts 91.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3990      +/-   ##
==========================================
+ Coverage   59.60%   59.80%   +0.21%     
==========================================
  Files         938      936       -2     
  Lines       41226    41069     -157     
  Branches     8678     8639      -39     
==========================================
- Hits        24568    24559       -9     
+ Misses      16564    16416     -148     
  Partials       94       94              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant