[build-tools] pass metrics CORS origin to serve-sim#3990
Draft
gwdp wants to merge 1 commit into
Draft
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
34cbd57 to
54257fd
Compare
54257fd to
1230799
Compare
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3990 +/- ##
==========================================
+ Coverage 59.60% 59.80% +0.21%
==========================================
Files 938 936 -2
Lines 41226 41069 -157
Branches 8678 8639 -39
==========================================
- Hits 24568 24559 -9
+ Misses 16564 16416 -148
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
so the expo.dev dashboard can read serve-sim's live
/metricsstream cross-origin.How
reads
EAS_SIMULATOR_METRICS_CORS_ORIGINfrom the worker env and passes it to serve-sim as--metrics-cors-originwhen launching the tunnel. optional (unset = no cross-origin reads), and a comma-separated value becomes one flag per origin (prod + staging).Test Plan
CI passes. unit tests cover the env getter and the arg builder.