Skip to content

[codex] fix fast-xml-builder dependabot alert#3966

Merged
szdziedzic merged 2 commits into
mainfrom
szdziedzic-codex/fix-dependabot-400-fast-xml-builder
Jul 13, 2026
Merged

[codex] fix fast-xml-builder dependabot alert#3966
szdziedzic merged 2 commits into
mainfrom
szdziedzic-codex/fix-dependabot-400-fast-xml-builder

Conversation

@szdziedzic

@szdziedzic szdziedzic commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Why

Dependabot reported alert 400 for fast-xml-builder (GHSA-5wm8-gmm8-39j9, CVE-2026-44665). Versions up to and including 1.1.6 are vulnerable to XML attribute injection when attribute values contain quotes and entity processing is disabled.

How

Re-resolved the Yarn lockfile so fast-xml-parser@5.4.1 uses fast-xml-builder@1.2.1, which is above the patched 1.1.7 release. Added a changelog entry for the security fix.

Test Plan

  • corepack yarn fmt
  • corepack yarn install --immutable
  • corepack yarn why fast-xml-builder
  • corepack yarn lint-changelog
  • git diff --check

corepack yarn install --immutable still reports the existing peer dependency warnings for graphql, oxlint-tsgolint, eslint, and @types/node.

@szdziedzic szdziedzic requested a review from sjchmiela July 6, 2026 20:19
@szdziedzic szdziedzic marked this pull request as ready for review July 6, 2026 20:19
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.72%. Comparing base (8204d18) to head (d85c6cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3966   +/-   ##
=======================================
  Coverage   59.72%   59.72%           
=======================================
  Files         941      941           
  Lines       41322    41322           
  Branches     8676     8676           
=======================================
  Hits        24674    24674           
  Misses      16554    16554           
  Partials       94       94           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szdziedzic szdziedzic requested a review from douglowder July 7, 2026 09:10
@szdziedzic szdziedzic force-pushed the szdziedzic-codex/fix-dependabot-400-fast-xml-builder branch from c89720c to d85c6cb Compare July 13, 2026 14:49
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit b2f34e5 into main Jul 13, 2026
10 checks passed
@szdziedzic szdziedzic deleted the szdziedzic-codex/fix-dependabot-400-fast-xml-builder branch July 13, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants