fix: Change extruder count for post-H2D introduction#24
Open
AJ-Owen wants to merge 1 commit into
Open
Conversation
The first filament swap gets skipped in versions of Bambustudio post the release of the H2D dual-extruder printer. Changing from `toolchange_count = 1` to `toolchange_count >= 1` is necessary to get the first filament swap to enter the conditional branch.
|
I just tested this on my P1S running firmware 1.7.0.x on bambu studio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first filament swap gets skipped in versions of Bambustudio post the release of the H2D dual-extruder printer. (tested on
BambuStudio-02.01.00.59andBambuStudio-02.01.01.52).Inspecting the generated .gcode files shows that the
toolchange_count = 1conditional does not get triggered on the first filament swap. Subsequent swaps use the edited gcode as intended.Changing to
toolchange_count >= 1results in the expected behaviour on all swaps.This has been tested on my A1M:
See the discussion in this issue for further context and possible P1 series fixes.