BAEL-973 Apache Commons Commons IO#2262
Conversation
KevinGilmore
left a comment
There was a problem hiding this comment.
Use the standard formatter to correct the indentation.
|
|
||
| public class FileMonitor { | ||
|
|
||
| public static void main(String[] args) throws Exception { |
There was a problem hiding this comment.
Need to use spaces (not tabs) for indentation. There's a standard formatter for Eclipse that you can import -- see the "eclipse" folder of the tutorials repo.
|
I'll check this tonight. Thanks 👍 |
|
@KevinGilmore formatted using formatter.xml. Thanks |
KevinGilmore
left a comment
There was a problem hiding this comment.
Couple of changes needed in the unit test file -- see the file for comments. Also the module does not build -- this is the second PR I have come across today with the same issue, so it seems that maybe someone committed an old version of the pom. Will investigate.
| } | ||
|
|
||
| @Test | ||
| public void whenUsingFileNameUtils_showdifferentFileOperations() |
There was a problem hiding this comment.
missing the "then" part of the test name
| } | ||
|
|
||
| @Test | ||
| public void whenGetFilewithNameFileFilter_then_FindfileTesttxt() |
There was a problem hiding this comment.
Don't need underscore after the word "then"
@kevin - Changes were made as per your request. Thanks.