separate test datasource#1575
Merged
KevinGilmore merged 4 commits intoeugenp:masterfrom Apr 7, 2017
lor6:BAEL-735
Merged
Conversation
KevinGilmore
suggested changes
Apr 6, 2017
Contributor
KevinGilmore
left a comment
There was a problem hiding this comment.
Rename "foundedEntity" variable in tests.
|
|
||
| @Test | ||
| public void givenGenericEntityRepository_whenSaveAndRetreiveEntity_thenOK() { | ||
| GenericEntity genericEntity = genericEntityRepository.save(new GenericEntity("test")); |
Contributor
There was a problem hiding this comment.
Let's change the variable name to "foundEntity"
| @Test | ||
| public void givenGenericEntityRepository_whenSaveAndRetreiveEntity_thenOK() { | ||
| GenericEntity genericEntity = genericEntityRepository.save(new GenericEntity("test")); | ||
| GenericEntity foundedEntity = genericEntityRepository.findOne(genericEntity.getId()); |
KevinGilmore
approved these changes
Apr 7, 2017
KevinGilmore
suggested changes
Apr 7, 2017
Contributor
KevinGilmore
left a comment
There was a problem hiding this comment.
Move H2TestProfileJPAConfig class to the src/test/java folder structure
| @@ -0,0 +1,66 @@ | |||
| package org.baeldung.config; | |||
Contributor
There was a problem hiding this comment.
This file should be moved to src/test/java
KevinGilmore
approved these changes
Apr 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.