Skip to content

Comparator comparing #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshiparthin wants to merge 6 commits into from
Closed

Comparator comparing #1464

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
21def42
Initial commit for Comparator.comparing article.
joshiparthin Mar 1, 2017
b3ce612
Changes in the code as per suggestions in review.
joshiparthin Mar 9, 2017
edd2be4
Change in test names as per suggestions...
joshiparthin Mar 20, 2017
6f43da9
Merge branch 'master' into comparator_comparing
joshiparthin Mar 21, 2017
f90c9e2
Changes in tests names for nullFirst and nullLast cases
joshiparthin Mar 21, 2017
e7d38c0
clean up.
joshiparthin Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 11 additions & 47 deletions core-java/src/test/java/com/baeldung/java8/comparator/Java8ComparatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,15 @@ public void initData() {
}

@Test
public void givenEmployeeArray_whenUsingComparing_thenCheckingSort() {
public void whenComparing_thenSortedByName() {
Comparator<Employee> employeeNameComparator = Comparator.comparing(Employee::getName);
Arrays.sort(employees, employeeNameComparator);
// System.out.println(Arrays.toString(employees));
assertTrue(Arrays.equals(employees, sortedEmployeesByName));
}

@Test
public void givenEmployeeArray_whenUsingComparingWithComparator_thenCheckingSort() {
public void whenComparingWithComparator_thenSortedByNameDesc() {
Comparator<Employee> employeeNameComparator = Comparator.comparing(Employee::getName, (s1, s2) -> {
return s2.compareTo(s1);
});
Expand All @@ -78,47 +78,47 @@ public void givenEmployeeArray_whenUsingComparingWithComparator_thenCheckingSort
}

@Test
public void givenEmployeeArray_whenUsingComparingInt_thenCheckingSort() {
public void whenComparingInt_thenSortedByAge() {
Comparator<Employee> employeeAgeComparator = Comparator.comparingInt(Employee::getAge);
Arrays.sort(employees, employeeAgeComparator);
// System.out.println(Arrays.toString(employees));
assertTrue(Arrays.equals(employees, sortedEmployeesByAge));
}

@Test
public void givenEmployeeArray_whenUsingComparingLong_thenCheckingSort() {
public void whenComparingLong_thenSortedByMobile() {
Comparator<Employee> employeeMobileComparator = Comparator.comparingLong(Employee::getMobile);
Arrays.sort(employees, employeeMobileComparator);
// System.out.println(Arrays.toString(employees));
assertTrue(Arrays.equals(employees, sortedEmployeesByMobile));
}

@Test
public void givenEmployeeArray_whenUsingComparingDouble_thenCheckingSort() {
public void whenComparingDouble_thenSortedBySalary() {
Comparator<Employee> employeeSalaryComparator = Comparator.comparingDouble(Employee::getSalary);
Arrays.sort(employees, employeeSalaryComparator);
// System.out.println(Arrays.toString(employees));
assertTrue(Arrays.equals(employees, sortedEmployeesBySalary));
}

@Test
public void givenEmployeeArray_whenUsingNaturalOrder_thenCheckingSort() {
public void whenNaturalOrder_thenSortedByName() {
Comparator<Employee> employeeNameComparator = Comparator.<Employee> naturalOrder();
Arrays.sort(employees, employeeNameComparator);
// System.out.println(Arrays.toString(employees));
assertTrue(Arrays.equals(employees, sortedEmployeesByName));
}

@Test
public void givenEmployeeArray_whenUsingReverseOrder_thenCheckingSort() {
public void whenReverseOrder_thenSortedByNameDesc() {
Comparator<Employee> employeeNameComparator = Comparator.<Employee> reverseOrder();
Arrays.sort(employees, employeeNameComparator);
// System.out.println(Arrays.toString(employees));
assertTrue(Arrays.equals(employees, sortedEmployeesByNameDesc));
}

@Test
public void givenEmployeeArray_whenUsingNullFirst_thenCheckingSort() {
public void whenNullsFirst_thenSortedByNameWithNullsFirst() {
Comparator<Employee> employeeNameComparator = Comparator.comparing(Employee::getName);
Comparator<Employee> employeeNameComparator_nullFirst = Comparator.nullsFirst(employeeNameComparator);
Arrays.sort(employeesArrayWithNulls, employeeNameComparator_nullFirst);
Expand All @@ -127,7 +127,7 @@ public void givenEmployeeArray_whenUsingNullFirst_thenCheckingSort() {
}

@Test
public void givenEmployeeArray_whenUsingNullLast_thenCheckingSort() {
public void whenNullsLast_thenSortedByNameWithNullsLast() {
Comparator<Employee> employeeNameComparator = Comparator.comparing(Employee::getName);
Comparator<Employee> employeeNameComparator_nullLast = Comparator.nullsLast(employeeNameComparator);
Arrays.sort(employeesArrayWithNulls, employeeNameComparator_nullLast);
Expand All @@ -136,7 +136,7 @@ public void givenEmployeeArray_whenUsingNullLast_thenCheckingSort() {
}

@Test
public void givenEmployeeArray_whenUsingThenComparing_thenCheckingSort() {
public void whenThenComparing_thenSortedByAgeName() {
Comparator<Employee> employee_Age_Name_Comparator = Comparator.comparing(Employee::getAge).thenComparing(Employee::getName);

Arrays.sort(someMoreEmployees, employee_Age_Name_Comparator);
Expand All @@ -145,48 +145,12 @@ public void givenEmployeeArray_whenUsingThenComparing_thenCheckingSort() {
}

@Test
public void givenEmployeeArray_whenUsingThenComparingInt_thenCheckingSort() {
public void whenThenComparing_thenSortedByNameAge() {
Comparator<Employee> employee_Name_Age_Comparator = Comparator.comparing(Employee::getName).thenComparingInt(Employee::getAge);

Arrays.sort(someMoreEmployees, employee_Name_Age_Comparator);
// System.out.println(Arrays.toString(someMoreEmployees));
assertTrue(Arrays.equals(someMoreEmployees, sortedEmployeesByNameAge));
}

@Before
public void printData() {
// System.out.println("employees");
// System.out.println(Arrays.toString(employees));
//
// System.out.println("employeesArrayWithNulls");
// System.out.println(Arrays.toString(employeesArrayWithNulls));
//
// System.out.println("sortedEmployeesByName");
// System.out.println(Arrays.toString(sortedEmployeesByName));
//
// System.out.println("sortedEmployeesByNameDesc");
// System.out.println(Arrays.toString(sortedEmployeesByNameDesc));
//
// System.out.println("sortedEmployeesByAge");
// System.out.println(Arrays.toString(sortedEmployeesByAge));
//
// System.out.println("sortedEmployeesByMobile");
// System.out.println(Arrays.toString(sortedEmployeesByMobile));
//
// System.out.println("sortedEmployeesBySalary");
// System.out.println(Arrays.toString(sortedEmployeesBySalary));
//
// System.out.println("sortedEmployeesArray_WithNullsFirst");
// System.out.println(Arrays.toString(sortedEmployeesArray_WithNullsFirst));
//
// System.out.println("sortedEmployeesArray_WithNullsLast");
// System.out.println(Arrays.toString(sortedEmployeesArray_WithNullsLast));
//
// System.out.println("sortedEmployeesByNameAge");
// System.out.println(Arrays.toString(sortedEmployeesByNameAge));
//
// System.out.println("someMoreEmployees");
// System.out.println(Arrays.toString(someMoreEmployees));
//
}
}