[BUGFIX] Fix NameError when requiring the Client class#59
Merged
sergio-bobillier merged 1 commit intomasterfrom Feb 19, 2026
Merged
[BUGFIX] Fix NameError when requiring the Client class#59sergio-bobillier merged 1 commit intomasterfrom
sergio-bobillier merged 1 commit intomasterfrom
Conversation
Fixes a NameError that occurred when requiring 'jay_api/elasticsearch/client' without requiring 'elasticsearch'. The error was happening because of two things: 1. The class's file was requiring 'elasticsearch/api/namespace/tasks', however, this file was not only not needed by the class but it cannot be directly required, because it tries to use Elasticsearch's Common::Client class without requiring it first, hence the NameError. 2. Requiring 'elasticsearch/transport/transport/errors', which is actually needed by the class, causes a NameError because it tries to use Timeout::Error without requiring 'timeout' first. So, to fix the issue a require statement for 'timeout' is being added. This error was only happening when the class was required directly, so it is mostly visible in unit tests.
sheputis
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
NameErrorthat occurred when requiring'jay_api/elasticsearch/client'without requiring'elasticsearch'. The error was happening because of two things:The class's file was requiring
'elasticsearch/api/namespace/tasks', however, this file was not only not needed by the class but it cannot be directly required, because it tries to use Elasticsearch'sCommon::Clientclass without requiring it first, hence theNameError.Requiring
'elasticsearch/transport/transport/errors', which is actually needed by the class, causes aNameErrorbecause it tries to useTimeout::Errorwithout requiring'timeout'first. So, to fix the issue a require statement for'timeout'is being added.This error was only happening when the class was required directly, so it is mostly visible in unit tests.