Skip to content

Conversation

@matthias-bs
Copy link
Contributor

@matthias-bs matthias-bs commented Feb 14, 2024

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

The previous board definition ESP32_DEV is used for several boards, i.e. it is not specific to the DFRobot FireBeetle ESP32 board. The proposed name has been chosen according to other DFRobot boards.

The change allows to compile code specific for the selected board. In my target application, a specific "FireBeetle Cover" (similar to a "HAT" or Adafruit's "Feather" concept) is assumed to be installed if this board is selected.

Tests scenarios

Related links

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello matthias-bs, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e821e51

@SuGlider SuGlider requested review from P-R-O-C-H-Y, SuGlider and georgik and removed request for georgik February 14, 2024 21:18
@SuGlider SuGlider modified the milestones: 3.0.1, 3.0.0-RC1 Feb 14, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. labels Feb 15, 2024
@me-no-dev me-no-dev merged commit 698b78a into espressif:master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants