[I2S][SR] Add new I2S library and Sound Recognition support #8714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
commented
Oct 16, 2023
me-no-dev
commented
Oct 16, 2023
me-no-dev
commented
Oct 16, 2023
| if(!perimanSetPinBus(_rx_din3, ESP32_BUS_TYPE_I2S_PDM, (void *)(this))){ goto err; } | ||
| } | ||
| break; | ||
| } |
Member
Author
There was a problem hiding this comment.
instead of having 4 cases one after another, have 4 separate private methods to init each type.
Member
There was a problem hiding this comment.
Done. A lot cleaner code now :)
Member
Author
|
Don't forget to fix the examples :) Also add some for the different modes. |
This was referenced Oct 18, 2023
Closed
1 task
This was referenced Feb 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of: #8617