Skip to content

ledc.c: Fix analogWrite() last channel available verification #8509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
me-no-dev merged 2 commits into from
Aug 29, 2023
Merged

ledc.c: Fix analogWrite() last channel available verification #8509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9075978
Fix analogWrite channel available verification
rlipas Aug 10, 2023
d4d7a68
Fix incorrect array initialization
rlipas Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cores/esp32/esp32-hal-ledc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,13 +234,13 @@ void analogWrite(uint8_t pin, int value) {
return;
}
ledcAttachPin(pin, channel);
pin_to_channel[pin] = channel;
pin_to_channel[pin] = channel + 1;
ledcWrite(channel, value);
}
}

int8_t analogGetChannel(uint8_t pin) {
return pin_to_channel[pin];
return pin_to_channel[pin] - 1;
}

void analogWriteFrequency(uint32_t freq) {
Expand Down