Fixed memory leaks in rainmaker examples #7965
Conversation
|
@shahpiyushv @vikramdattu Please take a look |
…er_example_changes
vikramdattu
left a comment
There was a problem hiding this comment.
Minor cosmetic issues. LGTM otherwise.
| my_device->updateAndReportParam(ESP_RMAKER_DEF_POWER_NAME, dimmer_state); | ||
| } | ||
| (dimmer_state == false) ? digitalWrite(gpio_dimmer, LOW) : digitalWrite(gpio_dimmer, HIGH); | ||
| } |
There was a problem hiding this comment.
Please follow same styling across the file
There was a problem hiding this comment.
We are losing time with style issues when an automatic script with clang formatter could keep all PR at same pattern.
There was a problem hiding this comment.
We have a script in IDF which uses astyle programme to achieve this: here. However this has to be run manually for this repo.
If you have a change for using automated clang formatter, would you please raise a PR for the same?
There was a problem hiding this comment.
I'm not an expert in this subject otherwise I could make a PR. Actually I'm using uncrustify in VSCode only.
Anyway there's an action with example for artistic style here:
https://github.com/marketplace/actions/artistic-style
| int endTime = millis(); | ||
|
|
||
| if ((endTime - startTime) > 10000) { | ||
| // If key pressed for more than 10secs, reset all |
Description of Change
This PR will fix the memory leaks (which existed for a long time but got exposed in the recent release) in Rainmaker examples and improves some error logs in the Rainmaker library.
NOTE: The actual memory allocation failures will be fixed in the Rainmaker C library.
Tests scenarios
I have tested this PR on esp32 wrover kit.
Related links
Related to #7893