More robust message wording test#862
Merged
nikosbosse merged 7 commits intoepiforecasts:mainfrom Jul 20, 2024
Merged
Conversation
nikosbosse
reviewed
Jul 18, 2024
Collaborator
|
@MichaelChirico thanks a lot for your recent contributions - much appreciate it. If you like, please add yourself as a contributor to the package DESCRIPTION. |
Contributor
Author
Don't feel I've contributed all that much, but thank you for the offer! And thanks for using data.table 👍 |
nikosbosse
approved these changes
Jul 19, 2024
Collaborator
nikosbosse
left a comment
There was a problem hiding this comment.
This looks great, thanks a lot!
nikosbosse
approved these changes
Jul 19, 2024
Contributor
Author
|
FYI data.table will release to CRAN in August, so expect to need a {scoringutils} update in the near future. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Rdatatable/data.table#6284.
The message upstream has been improved (here):
This will be released to CRAN soon. In general, it is a bit fragile to rely on the exact wording of another package's errors/warnings/messages. See here for how we try and be a bit more flexible in {data.table} when relying on {base} message text:
https://github.com/Rdatatable/data.table/blob/a01f00f7438daf4612280d6886e6929fa8c8f76e/inst/tests/tests.Rraw#L160-L202
Eventually, we'd like to offer you custom condition classes you can more reliably depend on instead:
Rdatatable/data.table#5913
In fact we already do so for the particular message you're relying on:
dt_missing_fun_aggregate_warning:https://github.com/Rdatatable/data.table/blob/0030b15d1ebc9242e30159351388ef3cc114e344/R/fcast.R#L185