fix: initial fetch timed out for type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.Secret#9532
fix: initial fetch timed out for type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.Secret#9532yuehaii wants to merge 1 commit into
Conversation
Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 109d46c6c5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| source.ConfigSourceSpecifier = &corev3.ConfigSource_Ads{ | ||
| Ads: &corev3.AggregatedConfigSource{}, | ||
| } | ||
| source.InitialFetchTimeout = durationpb.New(0) |
There was a problem hiding this comment.
This new field is present on every ConfigSource returned by makeConfigSource, so the serialized listeners/clusters will now include initialFetchTimeout: 0s. The translator tests compare the full serialized resources against internal/xds/translator/testdata/out (translator_test.go checks listeners and clusters directly), but those goldens still omit the field for existing ADS RDS/SDS config sources such as simple-tls.listeners.yaml, so go test ./internal/xds/translator will fail once the required Go toolchain is available. Please commit the regenerated translator/egctl golden outputs with this code change.
Useful? React with 👍 / 👎.
Issue description
the initial_fetch_timeout: 0s will disable timeout in envoy. however, that setting only applies to LDS and CDS, not to SDS (Secret). It caused initial fetch timed out for type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.Secret.
What this PR does / why we need it:
the sds_config can't be added in to dynamic_resources. the config.bootstrap.v3.Bootstrap.DynamicResources only has three fields listed below. the SDS go through xDS discovery.
{
"lds_config": {...},
"cds_config": {...},
"ads_config": {...}
}
This PR set xDS default InitialFetchTimeout as 0 to mitigate the issue.
Which issue(s) this PR fixes:
Fixes #9373
PR Checklist
git commit -s). See DCO: Sign your work.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.release-notes/current/breaking_changes/.