xDS: change ext_proc drain process to work directionally#45901
Open
markdroth wants to merge 4 commits into
Open
xDS: change ext_proc drain process to work directionally#45901markdroth wants to merge 4 commits into
markdroth wants to merge 4 commits into
Conversation
Signed-off-by: Mark D. Roth <roth@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth <roth@google.com>
Contributor
|
@yanjunxiang-google and @tyxia PTAL. |
Contributor
|
We might have some other changes when we actually support FULL_DUPLEX_STREAMED mode graceful drain in Envoy. Thus I would rather hold off any API changes for now until we have a PoC which clearly demonstrates what needs to be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: xDS: change ext_proc drain process to work directionally
Additional Description: Allow draining request and response bodies independently of each other in FULL_DUPLEX_STREAMED and GRPC body send modes.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A
CC @yanjunxiang-google