Make http/ratelimit exception free#38629
Merged
Merged
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
yanavlasov
approved these changes
Mar 5, 2025
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
Risk Level: low Testing: existing ones Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
Risk Level: low Testing: existing ones Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
yanavlasov
pushed a commit
that referenced
this pull request
Jul 16, 2026
…#46111) Migrate the ratelimit, rbac, and ext_authz network filter config factories from the throwing `Common::FactoryBase` to `Common::ExceptionFreeFactoryBase`, so config validation returns `absl::StatusOr` instead of throwing. This mirrors the already merged HTTP twins (#38629, #46035) and continues the exception free migration tracked in #27412. Error messages and failure semantics are unchanged (`EnvoyException` becomes `absl::InvalidArgumentError` with identical text). rbac's factory validation was the only throw in its directory, so its entry is removed from the `tools/code_format/config.yaml` exception allowlist, locking the directory throw free via `check_format`. ratelimit and ext_authz keep their entries: both retain throws outside the config validation surface (descriptor formatter, per connection client creation), left for a follow-up. The network read filter fuzz harness relied on factories throwing for invalid configs (`.value()` inside a `catch (EnvoyException)`). It now checks the returned status first, mirroring the HTTP fuzz harness, so error statuses keep exiting setup early instead of escaping as `BadStatusOrAccess` (caught by the `ext_authz_2` corpus entry, a V2 config). **Commit Message:** network: migrate ratelimit, rbac, ext_authz filters to exception free **Additional Description:** see above **Risk Level:** Low. Behavior preserving refactor, no user visible change. **Testing:** The three `config_test` targets and `//test/extensions/filters/network/common/fuzz:network_readfilter_fuzz_test` (which exercises the migrated error path via the `ext_authz_2` corpus) pass in the CI clang image. Added `DeprecatedV2TransportApiVersion` negative tests for ratelimit and ext_authz; rbac's `checkRule` expectations converted from `EXPECT_THROW` to status assertions. `check_format` passes with the rbac allowlist entry removed. **Docs Changes:** N/A **Release Notes:** N/A (internal refactor) **Platform Specific Features:** N/A Part of #27412 **Generative AI disclosure:** Developed with AI assistance (Claude Code); I reviewed and understand every line and take full ownership of the submission. Signed-off-by: David Vo <davidvo@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Make http/ratelimit exception free
Additional Description: n/a
Risk Level: low
Testing: existing ones
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a