python_shell: Pass __init__ keyword arguments also to _create_control#451
python_shell: Pass __init__ keyword arguments also to _create_control#451janvonrickenbach wants to merge 2 commits intoenthought:mainfrom
Conversation
…t constructor arguments of PyShell.
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 36.63% 36.61% -0.02%
==========================================
Files 481 481
Lines 26424 26424
Branches 3917 3917
==========================================
- Hits 9680 9676 -4
- Misses 16321 16323 +2
- Partials 423 425 +2
Continue to review full report at Codecov.
|
|
Thanks for the contribution! As you note, this probably isn't the best way to do it; in particular the keyword args are going to be wxPython-specific and so will break compatibility with the equivalent Qt toolkit widgets; and they also conflict with the way Traits initialises objects (notice that Which keyword arguments (ie. which features) are you particularly needing? With a little bit more work it may be possible to support them on both back-ends, probably by adding some additional Traits that reflect those particular needs. |
Not really sure if this is the best way to do it. I would like to pass arguments to the PyShell.init function.