Emscripten now handles exit() in pthreads#3
Conversation
…ad of exit() to report success." This reverts commit e350af1.
|
Great news! Again, thanks for working on this. Now that we have integrated this testsuite into emscripten should we consider moving to the emscripten-core org. @juj ? |
|
Yeah, looks good. |
SGTM, transferred at https://github.com/emscripten-core/posixtestsuite. |
|
Nice! |
|
@kleisauke do you want to submit a PR updating the the submodule? |
|
Yes, I could update that sometime next week (I'm quite busy with the musl upgrade now). |
|
A musl upgrade for emscripten? I've also be working on that on an off.. not sure how close you are but I got down the a single test failure IIRC. I don't many giving up my attempt as long as you don't mind he having some options about it :) Let me upload my work in progress... |
|
Sorry that I caused double work. My main focus was on updating the threading implementation to musl 1.2.1 (for e.g. |
|
No worries! I was also my fault for not mentioning I had started to look at it. Happy to go either direction. |
This PR reverts a Emscripten specific change to the Open POSIX Test Suite. Since PR emscripten-core/emscripten#12933 (Emscripten v2.0.10) commit e350af1 can be safely reverted as
exit()calls are now being proxied back to the main thread./cc @sbc100 as he is the author of emscripten-core/emscripten#12933.