Skip to content

Emscripten now handles exit() in pthreads#3

Merged
juj merged 1 commit into
emscripten-core:masterfrom
kleisauke:exit_from_pthread
Dec 10, 2020
Merged

Emscripten now handles exit() in pthreads#3
juj merged 1 commit into
emscripten-core:masterfrom
kleisauke:exit_from_pthread

Conversation

@kleisauke
Copy link
Copy Markdown
Collaborator

This PR reverts a Emscripten specific change to the Open POSIX Test Suite. Since PR emscripten-core/emscripten#12933 (Emscripten v2.0.10) commit e350af1 can be safely reverted as exit() calls are now being proxied back to the main thread.

/cc @sbc100 as he is the author of emscripten-core/emscripten#12933.

…ad of exit() to report success."

This reverts commit e350af1.
@sbc100
Copy link
Copy Markdown
Contributor

sbc100 commented Dec 6, 2020

Great news!

Again, thanks for working on this.

Now that we have integrated this testsuite into emscripten should we consider moving to the emscripten-core org. @juj ?

@juj juj merged commit d8b4410 into emscripten-core:master Dec 10, 2020
@juj
Copy link
Copy Markdown
Collaborator

juj commented Dec 10, 2020

Yeah, looks good.

@juj
Copy link
Copy Markdown
Collaborator

juj commented Dec 10, 2020

Now that we have integrated this testsuite into emscripten should we consider moving to the emscripten-core org. @juj ?

SGTM, transferred at https://github.com/emscripten-core/posixtestsuite.

@sbc100
Copy link
Copy Markdown
Contributor

sbc100 commented Dec 10, 2020

Nice!

@sbc100
Copy link
Copy Markdown
Contributor

sbc100 commented Dec 10, 2020

@kleisauke do you want to submit a PR updating the the submodule?

@kleisauke kleisauke deleted the exit_from_pthread branch December 10, 2020 17:36
@kleisauke
Copy link
Copy Markdown
Collaborator Author

Yes, I could update that sometime next week (I'm quite busy with the musl upgrade now).

@sbc100
Copy link
Copy Markdown
Contributor

sbc100 commented Dec 10, 2020

A musl upgrade for emscripten? I've also be working on that on an off.. not sure how close you are but I got down the a single test failure IIRC. I don't many giving up my attempt as long as you don't mind he having some options about it :)

Let me upload my work in progress...

@kleisauke
Copy link
Copy Markdown
Collaborator Author

Sorry that I caused double work. My main focus was on updating the threading implementation to musl 1.2.1 (for e.g. pthread_testcancel, pthread_detach, pthread_cancel and pthread_join were moved from JS to musl now), so hopefully it doesn't collide too much with your changes.

@sbc100
Copy link
Copy Markdown
Contributor

sbc100 commented Dec 11, 2020

No worries! I was also my fault for not mentioning I had started to look at it. Happy to go either direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants