No win32api

[aminya]

Revives and Closes #91

Fixes #210

[sbc100]

This is great!

Is it really this simple? We don't loose anything in this transition?

[aminya]

This is great!

Is it really this simple? We don't loose anything in this transition?

Thank you! Based on my personal tests and the unit tests, there is no behavior change.

If we can merge #515 before this, we can become fully sure that this works.

[sbc100]

I'm happy to land this now if you think its safe. I've not yet has a change to look at #515 but it looks a little more invasive. Do you want to land this now or wait for #515?

[aminya]

I tested this with #515 on my master branch. It works:

❯ .\emsdk.ps1 activate --permanent
Registering active Emscripten environment permanently

Setting the following tools as active:
   node-12.18.1-64bit
   python-3.7.4-pywin32-64bit
   java-8.152-64bit

Adding directories to PATH:
PATH += C:\Users\aminy\Documents\GitHub\Cpp\emsdk
PATH += C:\Users\aminy\Documents\GitHub\Cpp\emsdk\node\12.18.1_64bit\bin
PATH += C:\Users\aminy\Documents\GitHub\Cpp\emsdk\python\3.7.4-pywin32_64bit
PATH += C:\Users\aminy\Documents\GitHub\Cpp\emsdk\java\8.152_64bit\bin

Setting global environment variables:
PATH = C:\Users\aminy\Documents\GitHub\Cpp\emsdk;C:\Users\aminy\Documents\GitHub\Cpp\emsdk\node\12.18.1_64bit\bin;C:\Users\aminy\Documents\GitHub\Cpp\emsdk\python\3.7.4-pywin32_64bit;C:\Users\aminy\Documents\GitHub\Cpp\emsdk\java\8.152_64bit\bin;C:\Program Files\Conan\conan;C:\Users\aminy\AppData\Local\atom\bin;C:\Program Files (x86)\JetBrains\WebStorm 2020.2\bin;C:\Users\aminy\AppData\Local\atom-nightly\bin;C:\Program Files\Google\Chrome\Application;C:\Program Files\CMake\bin
EMSDK = C:/Users/aminy/Documents/GitHub/Cpp/emsdk
EM_CONFIG = C:\Users\aminy\Documents\GitHub\Cpp\emsdk\.emscripten
EMSDK_NODE = C:\Users\aminy\Documents\GitHub\Cpp\emsdk\node\12.18.1_64bit\bin\node.exe
EMSDK_PYTHON = C:\Users\aminy\Documents\GitHub\Cpp\emsdk\python\3.7.4-pywin32_64bit\python.exe
JAVA_HOME = C:\Users\aminy\Documents\GitHub\Cpp\emsdk\java\8.152_64bit

[sbc100]

Out of interest do you have any insight as to why we over ride $PATH during this function?

[aminya]

Good catch. I think we don't need this anymore! This is adding the python that ships with emsdk to PATH to perform win32api operations. Considering that it is removed, we can get rid of these.

[aminya]

990f370