Skip to content

2.0.5#625

Merged
kripken merged 1 commit into
masterfrom
update
Sep 28, 2020
Merged

2.0.5#625
kripken merged 1 commit into
masterfrom
update

Conversation

@kripken
Copy link
Copy Markdown
Member

@kripken kripken commented Sep 28, 2020

No description provided.

@kripken kripken requested a review from sbc100 September 28, 2020 22:10
@kripken kripken merged commit 7e841b5 into master Sep 28, 2020
@kripken kripken deleted the update branch September 28, 2020 22:25
@curiousdannii
Copy link
Copy Markdown
Contributor

curiousdannii commented Sep 29, 2020

The Docker image increased by 181MB. Unfortunate.

@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented Sep 29, 2020

That is unexpected. Can you tell what changed?

@curiousdannii
Copy link
Copy Markdown
Contributor

curiousdannii commented Sep 29, 2020

It's the contents of the /emsdk folder. I haven't tried to look and see what has changed inside it.

@curiousdannii
Copy link
Copy Markdown
Contributor

curiousdannii commented Oct 2, 2020 •
edited
Loading

The biggest difference looks like 490MB (decompressed) in node_modules. And the big difference there is closure compiler (numbers are MB):

2.0.4
36	google-closure-compiler-osx
35	google-closure-compiler-windows
35	google-closure-compiler-linux
11	google-closure-compiler-java

2.0.5
288	google-closure-compiler-linux
273	google-closure-compiler-osx
40	google-closure-compiler-windows
10	google-closure-compiler-java

@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented Oct 2, 2020

I think that stuff is all downloaded after the emsdk bundle when we run npm ci as a post-install step. Looks like maybe bug in the google-closure-compiler npm package?

@curiousdannii
Copy link
Copy Markdown
Contributor

curiousdannii commented Oct 2, 2020 •
edited
Loading

So between June and now the individual platform packages increased massively:
https://www.npmjs.com/package/google-closure-compiler-linux/v/20200614.0.0
https://www.npmjs.com/package/google-closure-compiler-linux/v/20200920.0.0

See google/closure-compiler-npm#186

The three platform dependencies are marked as optional. Maybe you can run npm with a no-optional mode? I don't know much about that though, sorry.

@curiousdannii curiousdannii mentioned this pull request Oct 2, 2020
Closed
curiousdannii added a commit to curiousdannii/emsdk that referenced this pull request Oct 2, 2020
@curiousdannii
Skip installing optional npm deps, but then manually install the appr…
2fa8f27 
…opriate Closure Compiler native package

Follow on to emscripten-core#625
Fixes emscripten-core/emscripten#12406
@curiousdannii curiousdannii mentioned this pull request Oct 2, 2020
Merged
sbc100 pushed a commit that referenced this pull request Oct 6, 2020
@curiousdannii
Skip installing optional npm deps, but manually install Closure Compi…
47b7f85 
…ler native package (#630)

Follow on to #625
Fixes emscripten-core/emscripten#12406
curiousdannii added a commit to curiousdannii/emsdk that referenced this pull request Oct 8, 2020
@curiousdannii
Skip installing optional npm deps, but then manually install the appr…
bda34a9 
…opriate Closure Compiler native package

Follow on to emscripten-core#625, emscripten-core#630, emscripten-core#632, emscripten-core#633
Fixes emscripten-core/emscripten#12406
@curiousdannii curiousdannii mentioned this pull request Oct 8, 2020
Merged
sbc100 pushed a commit that referenced this pull request Oct 9, 2020
@curiousdannii
Skip installing optional npm deps, but manually install Closure Compi…
107dc62 
…ler native package (#636)

Follow on to #625, #630, #632, #633
Fixes emscripten-core/emscripten#12406
akoeplinger pushed a commit to akoeplinger/emsdk that referenced this pull request Dec 13, 2024
@dotnet-maestro
[main] Update dependencies from dotnet/source-build-reference-package…
487a0a4 
…s dotnet/llvm-project dotnet/cpython dotnet/binaryen dotnet/node (emscripten-core#625)

[main] Update dependencies from dotnet/source-build-reference-packages dotnet/llvm-project dotnet/cpython dotnet/binaryen dotnet/node
wtu87830895-svg pushed a commit to wtu87830895-svg/emsdk2 that referenced this pull request Dec 20, 2025
@curiousdannii
Skip installing optional npm deps, but manually install Closure Compi…
6bc2455 
…ler native package (#630)

Follow on to emscripten-core/emsdk#625
Fixes emscripten-core/emscripten#12406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kripken @curiousdannii @sbc100