Drop "-upstream" suffix from docker image name#530
Merged
Conversation
Collaborator
Author
f1e9230 to
ef5e24d
Compare
Collaborator
Author
|
Also remove the fastcomp binaries which we currently ship in the upstream SDK for historical reasons (this will save a bunch of space). |
kripken
approved these changes
Jun 24, 2020
trzecieu
approved these changes
Jun 24, 2020
trzecieu
left a comment
Collaborator
There was a problem hiding this comment.
I can see that currently emsdk install X.Y.Z does the same operation like emsdk install X.Y.Z-upstream 👍 and both operation succeeded.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.