Skip to content

Prefer arm64 over aarch64 internally. NFC#1246

Merged
sbc100 merged 1 commit into
mainfrom
arm64
Jun 27, 2023
Merged

Prefer arm64 over aarch64 internally. NFC#1246
sbc100 merged 1 commit into
mainfrom
arm64

Conversation

@sbc100

@sbc100 sbc100 commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

This seems like more commonly known/used name for the architecture these days.

@sbc100 sbc100 requested a review from dschuff June 27, 2023 15:32
This seems like more commonly known/used name for the architecture
these days.
@sbc100 sbc100 enabled auto-merge (squash) June 27, 2023 16:14

@dschuff dschuff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC uname -m and platform.machine() return aarch64 on Linux and arm64 on MacOS. Not sure about Windows. So we do have to keep handling both values, but I agree arm64 is more understandable for internal values.

Comment thread emsdk.py
elif machine.startswith('aarch64') or machine.lower().startswith('arm64'):
ARCH = 'aarch64'
if WINDOWS:
errlog('No support for Windows on Arm, fallback to x64')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this actually work? i.e. does Windows ARM64 have automatic emulation the way MacOS does?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume so.. I just moved this code from below, I didn't create or change it.

@sbc100 sbc100 merged commit 1d59cd2 into main Jun 27, 2023
@sbc100 sbc100 deleted the arm64 branch June 27, 2023 20:46
shlomif pushed a commit to shlomif/emsdk that referenced this pull request Sep 29, 2023
This seems like more commonly known/used name for the architecture
these days.
rachelmsimm pushed a commit to rachelmsimm/emsdk that referenced this pull request Feb 22, 2025
juj pushed a commit to Unity-Technologies/emsdk that referenced this pull request Feb 27, 2025
* Update mac arm64 version of node

* Add debug log

* Try add new main sdk version

* Clarify architecture

* Remove architecture specification

* Remove log

* Cherry pick commit: Prefer `arm64` over `aarch64` internally. NFC (emscripten-core#1246)

* Remove extra new line

* Use older node version for intel mac

---------

Co-authored-by: Sam Clegg <sbc@chromium.org>
mmorel-35 pushed a commit to mmorel-35/emsdk that referenced this pull request Feb 3, 2026
This seems like more commonly known/used name for the architecture
these days.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants