Conversation
…mory handling in that case
jgravelle-google
approved these changes
Sep 23, 2019
|
Can you try after https://reviews.llvm.org/rL372708? |
Member
Author
|
Thanks @davidbolvansky, I subscribed to that review and I'll try after it lands. |
|
It landed |
Member
Author
|
Oh thanks, I don't read much LLVM reviews and I missed the landed part there. Yes, looks like we don't need the workaround anymore, I opened #9508 |
|
Thanks :) |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…ompiler-rt, etc. (emscripten-core#9483) Clang added a new warning, -Wint-in-bool-context, which warns on common stuff in musl, compiler-rt, etc., like (x >> 1) ? y : z. Instead of modifying a bunch of places in those projects, it seems best to ignore the warning in system libs for now, and eventually when we upgrade them they'll be fixed. The new clang hasn't rolled, so CI here doesn't have a clang build that recognizes that, so temporarily pass -Wno-unknown-warning-option so we can pass here. That way we can keep all CI green while getting the LLVM roll in.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…re precise. (emscripten-core#9508) Followup for emscripten-core#9483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang added a new warning,
-Wint-in-bool-context, which warns on common stuff in musl, compiler-rt, etc., like(x >> 1) ? y : z. Instead of modifying a bunch of places in those projects, it seems best to ignore the warning in system libs for now, and eventually when we upgrade them they'll be fixed.The new clang hasn't rolled, so CI here doesn't have a clang build that recognizes that, so temporarily pass
-Wno-unknown-warning-optionso we can pass here. That way we can keep all CI green while getting the LLVM roll in.