Skip to content

Add initial mac testing on CircleCI#9463

Merged
sbc100 merged 1 commit into
incomingfrom
mac_testing
Sep 20, 2019
Merged

Add initial mac testing on CircleCI#9463
sbc100 merged 1 commit into
incomingfrom
mac_testing

Conversation

@sbc100

@sbc100 sbc100 commented Sep 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

No description provided.

@sbc100 sbc100 force-pushed the mac_testing branch 4 times, most recently from fcb8f65 to e2a5d96 Compare September 20, 2019 16:06
@sbc100 sbc100 requested a review from kripken September 20, 2019 16:06
@sbc100 sbc100 changed the title Add initial mac testing Add initial mac testing on CircleCI Sep 20, 2019
kripken
kripken reviewed Sep 20, 2019
View reviewed changes

@kripken kripken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why other? Not that I have a better idea, it does seem reasonable, but on the other hand it would have failed to catch the current regression...

Comment thread .circleci/config.yml
@sbc100

sbc100 commented Sep 20, 2019

Copy link
Copy Markdown
Collaborator Author

other is just the starting point. We can ramp it up over time.

@sbc100

sbc100 commented Sep 20, 2019

Copy link
Copy Markdown
Collaborator Author

I will add wasm2 as well actually

@sbc100

sbc100 commented Sep 20, 2019

Copy link
Copy Markdown
Collaborator Author

Do you know how I configure which circleci steps are "Required"?

kripken
kripken approved these changes Sep 20, 2019
View reviewed changes

@kripken kripken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I am slightly worried about the amount of extra work (time, resources, etc.) but it's not that bad I guess, and when we remove fastcomp we'll win a lot back.

@kripken

kripken commented Sep 20, 2019

Copy link
Copy Markdown
Member

The required steps are in the admin section of the github UI for the repo, Settings => Branches => Branch Protection Rules.

@sbc100

sbc100 commented Sep 20, 2019

Copy link
Copy Markdown
Collaborator Author

The required steps are in the admin section of the github UI for the repo, Settings => Branches => Branch Protection Rules.

I share that concern. Thats why I'm limiting the number of tests we run on mac to a small subset.

@sbc100 sbc100 merged commit 9bb6994 into incoming Sep 20, 2019
@kripken kripken deleted the mac_testing branch September 20, 2019 18:22
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
@sbc100 @belraquib
Add initial mac testing (emscripten-core#9463)
f1d1ab8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kripken kripken kripken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbc100 @kripken