Skip to content

speed up make_table #9434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waterlike86 wants to merge 2 commits into from
+4 −1
Closed

speed up make_table #9434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db9f4b2
speed up make_function_tables_defs by checking if the item is in the …
waterlike86 Sep 13, 2019
98bbf7f
fix python linter
waterlike86 Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion emscripten.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,10 +1107,13 @@ def make_bad(target=None):
end = raw.rindex(']')
body = raw[start + 1:end].split(',')
if shared.Settings.EMULATED_FUNCTION_POINTERS:
# this speeds up this section when all_implemented is very big > 150000
notinImplemented = list(set(body) - set(all_implemented))

@sbc100 sbc100 Sep 13, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be a lot faster if you dropped the list() since "if x in set" is O(1) rather than O(n) for "if x in list"?

@sbc100 sbc100 Sep 13, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact we change get_all_implemented to return a set then I think that should improve performance here and elsewhere significantly.

As far as I can tell the ordering of all_implemented is not important anywhere.

@sbc100 sbc100 Sep 13, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a stab a this, I hope you don't mind: #9435

@waterlike86 waterlike86 Sep 14, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sbc100 let me test out your changes report the numbers

@waterlike86 waterlike86 Sep 14, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sbc100 the reduction is similar. but your changes are better. Thanks! going to close this


def receive(item):
if item == '0':
return item
if item not in all_implemented:
if item in notinImplemented:
# this is not implemented; it would normally be wrapped, but with emulation, we just use it directly outside
return item
in_table.add(item)
Expand Down