Skip to content

[ci] Use newly official github action to install emsdk#26662

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:use_github_action
Apr 9, 2026
Merged

[ci] Use newly official github action to install emsdk#26662
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:use_github_action

Conversation

@sbc100
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 commented Apr 9, 2026

@sbc100 sbc100 force-pushed the use_github_action branch from f7dbb69 to c417ede Compare April 9, 2026 18:03
@sbc100 sbc100 requested review from dschuff and kripken April 9, 2026 18:05
Copy link
Copy Markdown
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is value in testing the old way too? Just to have the explicit list of commands and not depend on that side repo with the github action. E.g. a typo in that side repo could lead to us testing latest stable and not tot.

Or, put another way: do we have tests that the github action is doing exactly what it should? This will test it works, but I mean that it installs tot?

@sbc100
Copy link
Copy Markdown
Collaborator Author

sbc100 commented Apr 9, 2026

I wonder if there is value in testing the old way too? Just to have the explicit list of commands and not depend on that side repo with the github action. E.g. a typo in that side repo could lead to us testing latest stable and not tot.

Or, put another way: do we have tests that the github action is doing exactly what it should? This will test it works, but I mean that it installs tot?

We should have tests there yes.. but I don't think we need to block this change on that.. the main tested we do is still using circleci where we cannot/don't use these rules anyway.

@sbc100
Copy link
Copy Markdown
Collaborator Author

sbc100 commented Apr 9, 2026

Also, because its the codesize tests specifically that we updating here.. we would know very quickly if it was not tot that was being installed because we could get inconsistent codesize results (i.e. these tests are very sensitive to tot being the installed SDK).

Copy link
Copy Markdown
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good point about the code size tests.

@sbc100 sbc100 merged commit c22a176 into emscripten-core:main Apr 9, 2026
38 checks passed
@sbc100 sbc100 deleted the use_github_action branch April 9, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants