[ci] Use newly official github action to install emsdk#26662
Conversation
f7dbb69 to
c417ede
Compare
kripken
left a comment
There was a problem hiding this comment.
I wonder if there is value in testing the old way too? Just to have the explicit list of commands and not depend on that side repo with the github action. E.g. a typo in that side repo could lead to us testing latest stable and not tot.
Or, put another way: do we have tests that the github action is doing exactly what it should? This will test it works, but I mean that it installs tot?
We should have tests there yes.. but I don't think we need to block this change on that.. the main tested we do is still using circleci where we cannot/don't use these rules anyway. |
|
Also, because its the codesize tests specifically that we updating here.. we would know very quickly if it was not |
kripken
left a comment
There was a problem hiding this comment.
Nice, good point about the code size tests.
See https://github.com/emscripten-core/setup-emsdk