Fix test_js_base64_api test. NFC#26378
Merged
Merged
Conversation
In order to measure a difference with the native base64 API we need to disable the new `-sSINGLE_FILE_BINARY_ENCODE` setting.
dschuff
approved these changes
Mar 2, 2026
| self.node_args += ['--js_base_64'] | ||
| self.do_runf('hello_world.c', 'hello, world!', cflags=['-sSINGLE_FILE'], output_basename='baseline') | ||
| self.do_runf('hello_world.c', 'hello, world!', cflags=['-sSINGLE_FILE', '-sJS_BASE64_API', '-Wno-experimental']) | ||
| # JS_BASE64_API on has an effect when base64 is being used so we need to |
Member
There was a problem hiding this comment.
Suggested change
| # JS_BASE64_API on has an effect when base64 is being used so we need to | |
| # JS_BASE64_API only has an effect when base64 is being used so we need to |
sbc100
added a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to measure a difference with the native base64 API we need to disable the new
-sSINGLE_FILE_BINARY_ENCODEsetting.