Move emscripten_memprof_sbrk_grow into libtrace.js#26364
Merged
Conversation
emscripten_memprof_sbrk_grow into libtrace.js
9ff8a4d to
b18defd
Compare
a109631 to
998fb42
Compare
This allows for the complete removal of libmemoryprofiler.js since the memory profiler can now just use the same libtrace-based hooks for all events.
998fb42 to
839f2b3
Compare
Member
|
Should we add a changelog entry that the API has been renamed? |
kripken
approved these changes
Feb 27, 2026
Collaborator
Author
I don't think its should be necessary.. its a completely internal API (that caller and receiver are both part of emscripten). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for the complete removal of
libmemoryprofiler.jssince the memory profiler can now just use the same libtrace-based hooks for all events.I noticed this while reviewing #26175