Skip to content

Disable test_asyncify_indirect_lists in LTO mode #21765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 2 commits into from
Apr 15, 2024
Merged

Disable test_asyncify_indirect_lists in LTO mode #21765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9eb4df
work
kripken Apr 15, 2024
e313233
Merge remote-tracking branch 'origin/main' into add.lto
kripken Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8232,6 +8232,10 @@ def test_asyncify_lists(self, args, should_pass, response=None):
def test_asyncify_indirect_lists(self, args, should_pass):
self.set_setting('ASYNCIFY')
self.emcc_args += args
if '-flto' in str(self.emcc_args):
# LTO ends up inlining virt(), so ASYNCIFY_ADD does not work as expected.
# If wasm-opt were aware of LLVM's no-inline mark this would not happen.
self.skipTest('https://github.com/emscripten-core/emscripten/issues/21757')
try:
self.do_core_test('test_asyncify_indirect_lists.cpp', assert_identical=True)
if not should_pass:
Expand Down