Implement emscripten_promise_all_settled in promise.h

[tlively]

This is like emscripten_promise_all, but always fulfills and separately
reports whether each input promise is fulfilled or rejected.

[tlively]

Current dependencies on/for this PR:

• main
  • PR Implement emscripten_promise_all_settled in promise.h #19152 👈
    • PR Implement emscripten_promise_any in promise.h #19153
      • PR Implement emscripten_promise_race in promise.h #19154

This comment was auto-generated by Graphite.

[sbc100]

I don't think we using let yet in our library code. Can you stick to var?

[tlively]

Any ideas for how to work around this closure error?

building:ERROR: Closure compiler completed with warnings and -Werror=closure enabled, aborting!

building:ERROR: /tmp/emscripten_temp_3rigp9cj/main.js:19315:16: WARNING - [JSC_TYPE_MISMATCH] assignment
found   : (*|undefined)
required: number
  19315|                 HEAPU32[(((resultBuf)+(valueOffset))>>2)] = results[i].reason;
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

0 error(s), 1 warning(s), 72.6% typed

[tlively]

I just decided to suppress it for now. LMK if there's a better solution.

[tlively]

Yikes, it looks like some build modes remove the newline after the suppression comment, causing a new error.

Closure compiler completed with warnings and -Werror=closure enabled, aborting!

building:ERROR: /tmp/emscripten_temp_sykc9y08/main.jso1.js:11734:36: WARNING - [JSC_MISPLACED_SUPPRESS] @suppress annotation not allowed here. See https://github.com/google/closure-compiler/wiki/@suppress-annotations
  11734|       /** @suppress {checkTypes} */ SAFE_HEAP_STORE((((resultBuf) + (valueOffset)) >> 2) * 4, results[i].reason, 4);
                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

0 error(s), 1 warning(s), 68.6% typed

@sbc100, any ideas for workarounds?

[kripken]

TIL about allSettled...

[sbc100]

Any ideas for how to work around this closure error?

building:ERROR: Closure compiler completed with warnings and -Werror=closure enabled, aborting!

building:ERROR: /tmp/emscripten_temp_3rigp9cj/main.js:19315:16: WARNING - [JSC_TYPE_MISMATCH] assignment
found   : (*|undefined)
required: number
  19315|                 HEAPU32[(((resultBuf)+(valueOffset))>>2)] = results[i].reason;
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

0 error(s), 1 warning(s), 72.6% typed

I've not seen that before from the makeSetValue macros. Its basically saying it can't determine that results[i].reason is actually a number. Perhaps that type of the objects in the results array needs a type annotation? Let me see..

[sbc100]

So these promises only ever get rejected or fullfilled with Numbers? What happens if one of them is rejected to fulfilled with something that is not a number?

[tlively]

Yeah, they're always fulfilled or rejected with pointers because the fulfill values and reject reasons are always represented as void* in the C API.

[sbc100]

I think you can do something like this: var reason = /** @type {number} */ results[i].reason;

[tlively]

Is there a good way to generalize that for wasm64?

[sbc100]

We use number for pointer in wasm64 and wasm32 so it should just work.