[WasmFS] Allow removeChild to return specific error codes, and use it in OPFS#17793
Merged
Conversation
7 tasks
tlively
approved these changes
Sep 6, 2022
| throw "Did not get expected EIO when resizing file"; | ||
| } | ||
|
|
||
| if (Module._try_unlink() != 0) { |
Member
There was a problem hiding this comment.
We can also add another call to Module._try_unlink() down below after the access.close() to check that closing the out-of-band AccessHandle is enough to make the unlink work.
Member
Author
There was a problem hiding this comment.
Done. I had to add close() operations in the read and write calls in that test (otherwise an open fd prevents the unlink).
tlively
reviewed
Sep 6, 2022
Co-authored-by: Thomas Lively <7121787+tlively@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.