Prefer to check against thread ID for musl's rwlock. NFC.#15606
Merged
Conversation
sbc100
reviewed
Nov 23, 2021
Collaborator
sbc100
left a comment
There was a problem hiding this comment.
lgtm!
Maybe you could add some more detail to the PR description on title?
Collaborator
Author
|
OK, I changed the PR description and title to be more descriptive. Let me know if you want the commit message changed as well. (this change was split from commit 4afba04, which uses thread IDs in a couple more places) |
sbc100
approved these changes
Nov 23, 2021
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking against thread IDs should be preferred instead of casting
pthread_selfto a pointer. This should be safe to do after commitb2cfa35.
Split from PR #13007.