Free thread data in native code. NFC#15532
Closed
sbc100 wants to merge 1 commit into
Closed
Conversation
Thread data is now free'd in native code and no longer requires a postMessage back to the main thread. We free the thread data either when the thread exits (in the case it is detached) or when it is joined (in the case is not detached). In either case we can re-cycle the worker (return it to the worker pool) right away since the thread is no longer running. Since `freeThreadData` is no longer called during `returnWorkerToPool` it means that pthreads that are terminated asyncronously (with prejudice) will not leak their thread data. However terminating a thread in this way (using worker.terminate()) is already racey and dangerous since we don't know what state the diing thread is in, or exactly when it is safe to free its data.
kleisauke
approved these changes
Nov 17, 2021
Collaborator
kleisauke
left a comment
There was a problem hiding this comment.
Looks good to me, but there are a couple of test failures that need to be investigated further.
Added a small comment regarding that exit event.
| worker.onerror(e); | ||
| }); | ||
| worker.on('detachedExit', function() { | ||
| worker.on('threadDone', function() { |
Collaborator
There was a problem hiding this comment.
Suggested change
| worker.on('threadDone', function() { | |
| worker.on('exit', function() { |
See: #12861 (comment).
Collaborator
Author
|
I think i'm going to try to make an simpler NFC version of this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We free the thread data either when the thread exits (in the case it is
detached) or when it is joined (in the case it is not detached).
In either case we can re-cycle the worker (return it to the worker pool)
right away since the thread is no longer running.
Since
freeThreadDatais no longer called duringreturnWorkerToPoolit means that pthread data accocated with threads that were terminated
with worker.terminate will not be memory leaks. However terminating a
thread in this was otherwise racey and dangerous and we should try to
avoid
worker.terminateif at all possible. Also, pthread data isalready excluded from lsan so this won't show up in leak reports.