Skip to content

Eliminate type checks for float args #15428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billbudge merged 3 commits into from
Nov 9, 2021
Merged

Eliminate type checks for float args #15428

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d7f557
Let the VM convert JS values to the proper floating point type
Nov 2, 2021
dff6ea0
Merge branch 'main' into embind1
Nov 3, 2021
7bcdda4
Add old code gated by ASSERTIONS.
Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/embind/embind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,11 +642,13 @@ var LibraryEmbind = {
return value;
},
'toWireType': function(destructors, value) {
// todo: Here we have an opportunity for -O3 level "unsafe" optimizations: we could
// avoid the following if() and assume value is of proper type.
#if ASSERTIONS
if (typeof value !== "number" && typeof value !== "boolean") {
throw new TypeError('Cannot convert "' + _embind_repr(value) + '" to ' + this.name);
}
#endif
// The VM will perform JS to Wasm value conversion, according to the spec:
// https://www.w3.org/TR/wasm-js-api-1/#towebassemblyvalue

@sbc100 sbc100 Nov 4, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we put the old check behind "#if ASSERTIONS`?

@billbudge billbudge Nov 4, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam, I put the old code back gated by ASSERTIONS.

return value;
},
'argPackAdvance': 8,
Expand Down