build: add default for systemd user_unit_dir #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows building the service files without a systemd dependency by defining a default systemd user unit directory. Relevant in Alpine, where we can package the service files in a subpackage without having systemd in Alpine.
Owner
|
Why not install systemd at build-time to allow xdpw to discover the path properly? |
Author
|
Because we don't have systemd yet in Alpine, but allow systemd services to be shipped in a subpackage (e.g. for postmarketOS). Alternatively, i guesswe could also pass the path with a option. |
|
I think the typical pattern is to use |
Author
|
I'm currently enabling a dozen of systemd services in Alpine, and it looks to be a popular way used, yes. If you'd like that, I can do that here aswell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows building the service files without a systemd dependency by defining a default systemd user unit directory.
Relevant in Alpine, where we can package the service files in a subpackage without having systemd in Alpine.