Skip to content

feat: Add support for Sepolia and Holesky Ethereum testnets#17

Merged
splix merged 1 commit intoemeraldpay:masterfrom
legobeat:feat-sepolia-holesky
Mar 11, 2024
Merged

feat: Add support for Sepolia and Holesky Ethereum testnets#17
splix merged 1 commit intoemeraldpay:masterfrom
legobeat:feat-sepolia-holesky

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Mar 7, 2024

  • Add new entries for Chain.TESTNET_HOLESKY and Chain.TESTNET_SEPOLIA.

These are the contemporary public Ethereum testnets.

https://sepolia.dev

https://github.com/eth-clients/holesky

This seems required for being able to use these chains in Dshackle.


Blocked by

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2024

CLA assistant check
All committers have signed the CLA.

@legobeat legobeat force-pushed the feat-sepolia-holesky branch from 5deafa2 to 7b7c7a2 Compare March 7, 2024 09:12
@legobeat legobeat marked this pull request as draft March 7, 2024 13:27
@splix
Copy link
Member

splix commented Mar 9, 2024

@legobeat I see it's market as a Draft. Does it mean you're going to add additional commits?

@legobeat legobeat force-pushed the feat-sepolia-holesky branch from 7b7c7a2 to cc5539e Compare March 11, 2024 00:51
@legobeat
Copy link
Contributor Author

legobeat commented Mar 11, 2024

@legobeat I see it's market as a Draft. Does it mean you're going to add additional commits?

@splix Yes, was waiting for merge of emeraldpay/emerald-grpc#22 so I could update the submodule accordingly to get the protobuf definition synced. This has now been done so should be good to go.

@legobeat legobeat marked this pull request as ready for review March 11, 2024 00:52
@splix splix merged commit 6a87d45 into emeraldpay:master Mar 11, 2024
@splix
Copy link
Member

splix commented Mar 11, 2024

Thank you @legobeat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments