This repository was archived by the owner on Mar 22, 2019. It is now read-only.
Added RFCS sections#3385
Merged
jayjayjpg merged 2 commits intoemberjs:blog/embertimes#50from Jun 7, 2018
Merged
Conversation
jayjayjpg
reviewed
Jun 7, 2018
Member
jayjayjpg
left a comment
There was a problem hiding this comment.
That's a nice and descriptive write-up! I only left a few comments / questions regarding wording, otherwise, this looks 👍
|
|
||
|
|
||
| ## [RFCS Deprecating Ember Utils](https://github.com/emberjs/rfcs/pull/334) | ||
| A new RFCS has been posted on deprecating `Ember.{isEmpty, isBlank, isNone, isPresent}`. The motivation of this is to clean up utils that does not provide much value over writing plain old Javascript. There's already a discussion going on whether this is a good decision or not. You can follow the discussion and read the RFC at the [RFC repository](https://github.com/emberjs/rfcs/pull/334). |
Member
There was a problem hiding this comment.
I think it would be
to clean up utils that do not provide much [...]
| ## [SECTION TITLE](#section-url) | ||
|
|
||
|
|
||
| ## [RFCS Deprecating Ember Utils](https://github.com/emberjs/rfcs/pull/334) |
Member
There was a problem hiding this comment.
Is RFCS referring to RFCs or is it another term I don't know of yet? If not, would just RFC (=Request for Comments) be suitable?
Member
Author
There was a problem hiding this comment.
RFCS is a brain fart 🙈
jayjayjpg
approved these changes
Jun 7, 2018
Member
jayjayjpg
left a comment
There was a problem hiding this comment.
Thank you for another great write-up this week, @kennethlarsen ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.