introduce enable_compression parameter

[thweetkomputer]

Summary by CodeRabbit

• New Features
  • Added compression configuration option for EloqStore, enabling users to control compression behavior via command-line or configuration files.

[coderabbitai]

Walkthrough

The changes introduce a new compression configuration flag eloq_store_enable_compression for the EloqStore configuration system, with command-line flag taking precedence over INI file settings. Additionally, the destructor of EloqStoreDataStore is updated to explicitly use the override keyword to denote virtual function overriding.

Changes

Cohort / File(s)	Summary
Configuration Flag Addition eloq_data_store_service/eloq_store_config.cpp	New boolean configuration flag eloq_store_enable_compression (default: false) added. EloqStoreConfig initialization extended to populate enable_compression field from command-line or INI with proper precedence logic.
Destructor Override Declaration eloq_data_store_service/eloq_store_data_store.h	Destructor ~EloqStoreDataStore() updated from = default to override = default to explicitly mark it as overriding a base class virtual destructor.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that the enable_compression field is properly declared in the EloqStoreConfigs structure definition
• Confirm the precedence logic correctly implements command-line-over-INI pattern consistent with other flags
• Ensure the destructor override change is intentional and reflects actual base class virtuality

Poem

🐰 A rabbit hops with glee so bright,
Compression flags now set just right,
Destructors marked with override's might,
Config flows refined in morning light! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "introduce enable_compression parameter" directly relates to the primary feature being introduced in this changeset. The main changes involve adding a new configuration flag eloq_store_enable_compression and extending the EloqStoreConfig to populate and use this new field, which aligns precisely with what the title conveys. While the changeset also includes a minor modification to the destructor in eloq_store_data_store.h (adding the override keyword), this is a secondary refactoring that doesn't detract from the title's clarity about the primary intent. The title is specific, concise, and communicates the essential change without unnecessary noise.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch option-compression-zc

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 804a34d and 2921f90.

📒 Files selected for processing (2)

• eloq_data_store_service/eloq_store_config.cpp (2 hunks)
• eloq_data_store_service/eloq_store_data_store.h (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

eloq_data_store_service/eloq_store_config.cpp (1)

eloq_data_store_service/main.cpp (2)

• CheckCommandLineFlagIsDefault (90-102)
• CheckCommandLineFlagIsDefault (90-90)

🔇 Additional comments (3)

eloq_data_store_service/eloq_store_data_store.h (1)

167-167: LGTM! Good practice to explicitly mark override.

Adding the override keyword to the virtual destructor improves code clarity and enables compile-time verification that the base class has a virtual destructor.

eloq_data_store_service/eloq_store_config.cpp (2)

102-104: LGTM! Flag definition follows established conventions.

The new compression flag is properly defined using gflags with a safe default value (disabled) and clear documentation.

---

310-315: Verify that enable_compression field is properly defined in the external eloqstore::KvOptions library and is actually used.

The assignment pattern at lines 310-315 is correct and consistent with other configuration flags. However, the enable_compression field appears to be assigned but never used or read anywhere else in the codebase. Additionally, the field is defined in the external ::eloqstore::KvOptions type (not in a local EloqStoreConfigs struct as the original comment suggested), which cannot be verified from this repository alone.

Ensure that:

• The enable_compression field exists in the external eloqstore dependency's KvOptions struct
• This field is actually utilized by the eloqstore library or elsewhere in the system
• The assignment is not dead code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}