Update mtr test

[yi-xmu]

Update submodule

Summary by CodeRabbit

• Tests

  • Increased range-split recovery test coverage by adding additional debug scenarios and session-level debug settings to exercise recovery and replay behaviors under varied conditions.

• Chores

  • Updated an internal dependency reference to a newer commit.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b098495-7446-43db-8f0a-bcd7d19e1b9e

📥 Commits

Reviewing files that changed from the base of the PR and between fe4785d and e3862f8.

📒 Files selected for processing (1)

• data_substrate

✅ Files skipped from review due to trivial changes (1)

• data_substrate

---

Walkthrough

Updated the data_substrate submodule pointer to a new commit and inserted session-level debug_dbug settings into range-split recovery test and result files to set term_skip_auto_split_range around crash/restart segments.

Changes

Cohort / File(s)	Summary
Submodule Reference Update .gitmodules	Bumped data_substrate submodule commit from a64a31d7b5e87df17365794b995a325cdf153cb2 to 195439fa0cf60aa337b275ba85b13a0e05059f14.
Range Split Recovery Tests storage/eloq/mysql-test/mono_multi/t/range_split_recovery.test, storage/eloq/mysql-test/mono_multi/r/range_split_recovery.result	Added SET SESSION debug_dbug="+d,eloq;term_skip_auto_split_range;node_id=-1"; statements at multiple points after crash/restart directives to control auto-split behavior during recovery test phases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Range read block on rw conflict #229: Modifies Eloq MySQL test scripts to add/change session debug_dbug settings around range-split behavior (strongly related to the test changes).
• update submodule #186: Updates the data_substrate submodule pointer (same submodule pointer change).
• Update submodule #187: Updates the data_substrate submodule pointer (same kind of submodule update).

Suggested reviewers

• liunyl
• thweetkomputer

Poem

🐰 A tiny hop, a quiet tweak,
I set the flags so tests won't freak,
With debug lights and hops so spry,
Range splits snooze while logs go by,
Hooray for builds that pass—hip, hi! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Update mtr test' is vague and generic, using non-descriptive language that doesn't convey specific information about the actual changes made.	Provide a more specific title that describes the key change, such as 'Add debug_dbug directives to range_split_recovery test' or 'Update range split recovery test debugging configuration'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch update_mtr_test

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

storage/eloq/mysql-test/mono_multi/t/range_split_recovery.test (1)

15-15: Add explicit teardown for term_skip_auto_split_range to keep phases isolated.

These newly added session flags are enabled multiple times but never explicitly disabled. Adding a matching -d cleanup near existing panic-flag cleanups will reduce hidden cross-phase coupling in this long scenario.

Suggested cleanup pattern

+SET SESSION debug_dbug="-d,eloq;term_skip_auto_split_range;node_id=-1";

Also applies to: 39-39, 98-98, 141-141, 200-200

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@storage/eloq/mysql-test/mono_multi/t/range_split_recovery.test` at line 15,
The test enables the session debug flag "term_skip_auto_split_range" via SET
SESSION debug_dbug="+d,eloq;term_skip_auto_split_range;node_id=-1" but never
disables it, causing cross-phase coupling; add explicit teardown statements that
unset the flag (use the "-d" form) after the phases where it's set—place these
cleanup SET SESSION debug_dbug="-d,eloq;term_skip_auto_split_range;node_id=-1"
statements adjacent to the existing panic-flag cleanups so each phase isolates
changes; apply the same fix for the other occurrences at the indicated locations
(lines with similar SET SESSION debug_dbug invocations).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@storage/eloq/mysql-test/mono_multi/t/range_split_recovery.test`:
- Line 15: Update the debug flag strings in the test (the SET SESSION debug_dbug
lines in range_split_recovery.test at lines noted) to use the expected prefix
"eloq_test;term_skip_auto_split_range;node_id=-1" so the handler in ha_eloq.cc
recognizes them, then in ha_eloq.cc uncomment the call to run_eloq_test() inside
redirect_eloq_tests() so the handler actually executes tests, and finally
implement the missing test-path logic for term_skip_auto_split_range inside the
test handler (the branch handling "term_skip_auto_split_range" in the
run_eloq_test/handler code) so the recovery path is properly controlled during
the test.

---

Nitpick comments:
In `@storage/eloq/mysql-test/mono_multi/t/range_split_recovery.test`:
- Line 15: The test enables the session debug flag "term_skip_auto_split_range"
via SET SESSION debug_dbug="+d,eloq;term_skip_auto_split_range;node_id=-1" but
never disables it, causing cross-phase coupling; add explicit teardown
statements that unset the flag (use the "-d" form) after the phases where it's
set—place these cleanup SET SESSION
debug_dbug="-d,eloq;term_skip_auto_split_range;node_id=-1" statements adjacent
to the existing panic-flag cleanups so each phase isolates changes; apply the
same fix for the other occurrences at the indicated locations (lines with
similar SET SESSION debug_dbug invocations).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fbf3b47c-d119-41c0-9f54-391d22a376e5

📥 Commits

Reviewing files that changed from the base of the PR and between dab5150 and fe4785d.

📒 Files selected for processing (3)

• data_substrate
• storage/eloq/mysql-test/mono_multi/r/range_split_recovery.result
• storage/eloq/mysql-test/mono_multi/t/range_split_recovery.test