fix hash partition pre scan and standby forward cc request by adding missed check.#126
Conversation
WalkthroughSubmodule pointer for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
storage/eloq/tx_service (1)
1-1: Ensure CI/Docker flows init submodules to avoid broken builds.If any jobs build/test this repo, they must fetch submodules (e.g., git submodule update --init --recursive or checkout action with submodules: recursive). Verify Docker builds and release pipelines do the same.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
storage/eloq/tx_service(1 hunks)
🔇 Additional comments (1)
storage/eloq/tx_service (1)
1-1: Submodule bump — confirm intent & compatibility
- storage/eloq/tx_service updated: 2bd068afeac7e7621c15bd7ac718f6e96cd5ce73 → 655cd2d50f859ddebd26636d4fbdd73394040e68
- .gitmodules: path = storage/eloq/tx_service, url = https://github.com/eloqdata/tx_service.git
- CI: no workflows found that run submodule init/update or --recurse-submodules
Verify this pointer update is intentional and that the new tx_service commit is API/ABI/backwards-compatible, requires no on‑disk/migration changes, and that CI/builds handle the submodule (init/update or vendoring) if needed.
Summary by CodeRabbit