Skip to content

Increase eloqstore buffer pool size for ci test#425

Merged
githubzilla merged 1 commit intoeloqdata:mainfrom
githubzilla:fix_eloqstore_oom_on_ci
Jan 13, 2026
Merged

Increase eloqstore buffer pool size for ci test#425
githubzilla merged 1 commit intoeloqdata:mainfrom
githubzilla:fix_eloqstore_oom_on_ci

Conversation

@githubzilla
Copy link
Copy Markdown
Collaborator

@githubzilla githubzilla commented Jan 13, 2026

Summary by CodeRabbit

  • Chores
    • Updated data storage configuration settings to increase resource allocation limits for improved system performance and stability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 13, 2026

Walkthrough

Configuration parameters in the data substrate are updated to increase system capacity. The open files limit is increased from 1024 to 4096, and the buffer pool size is increased from 5MB to 500MB in the store section of the configuration file.

Changes

Cohort / File(s) Summary
Store Configuration
concourse/scripts/data_substrate.cnf
Updated eloq_store_open_files_limit from 1024 to 4096 and eloq_store_buffer_pool_size from 5MB to 500MB in [store] section

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • liunyl

Poem

🐰 Twitch twitch, resources flow free,

Four thousand files in harmony,

Five hundred megs of buffer bliss,

Configuration tuning—a rabbit's kiss! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: increasing eloq_store_buffer_pool_size (from 5MB to 500MB) in the configuration file for CI testing purposes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dfc2d5d and e4d25e9.

📒 Files selected for processing (1)
  • concourse/scripts/data_substrate.cnf
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 211
File: src/mongo/db/modules/eloq/cmake/build_eloq_log_service.cmake:26-80
Timestamp: 2025-09-25T12:24:06.434Z
Learning: The user githubzilla implemented a fix in commit fe98aaf to address the MEMORY state incorrectly triggering RocksDB discovery in build_eloq_log_service.cmake. This was a control flow issue where MEMORY builds were falling into an else branch that still attempted RocksDB discovery.
📚 Learning: 2025-11-28T10:55:21.020Z
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

  • concourse/scripts/data_substrate.cnf
🔇 Additional comments (1)
concourse/scripts/data_substrate.cnf (1)

18-19: LGTM! Reasonable configuration increases for CI stability.

The buffer pool size increase from 5MB to 500MB (100x) and open files limit from 1024 to 4096 (4x) are appropriate adjustments for addressing OOM issues. The 500MB buffer pool fits well within the 4GB node_memory_limit_mb configured on line 4.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@githubzilla githubzilla merged commit edfcb7c into eloqdata:main Jan 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants