Skip to content

Notify checkpoint scan workers when raising concurrency#358

Closed
thweetkomputer wants to merge 1 commit intoeloqdata:mainfrom
thweetkomputer:feat-notify-ckpt-zc
Closed

Notify checkpoint scan workers when raising concurrency#358
thweetkomputer wants to merge 1 commit intoeloqdata:mainfrom
thweetkomputer:feat-notify-ckpt-zc

Conversation

@thweetkomputer
Copy link
Copy Markdown
Collaborator

@thweetkomputer thweetkomputer commented Dec 11, 2025

Summary by CodeRabbit

  • Chores
    • Internal dependency update with no user-facing changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 11, 2025

Walkthrough

A submodule reference in src/mongo/db/modules/eloq/data_substrate was updated to point to a newer commit. No code or functionality changes are introduced in this repository.

Changes

Cohort / File(s) Change Summary
Submodule Update
src/mongo/db/modules/eloq/data_substrate
Bumped commit reference from 7802ebd to 02b3b20

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • lzxddz

Poem

🐰 A hop, a skip, a commit so fine,
The submodule points to a version divine,
No code was changed, just a pointer's new place,
Dependency bumped at a swift hopping pace! 🌙✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The pull request title 'Notify checkpoint scan workers when raising concurrency' does not match the actual changeset, which only updates a submodule reference with no functional changes. Update the title to reflect the actual change, such as 'Update data_substrate submodule reference' or similar, to accurately describe the submodule version bump.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0c6efa and fe11a9d.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 211
File: src/mongo/db/modules/eloq/cmake/build_eloq_log_service.cmake:26-80
Timestamp: 2025-09-25T12:24:06.434Z
Learning: The user githubzilla implemented a fix in commit fe98aaf to address the MEMORY state incorrectly triggering RocksDB discovery in build_eloq_log_service.cmake. This was a control flow issue where MEMORY builds were falling into an else branch that still attempted RocksDB discovery.
📚 Learning: 2025-11-28T10:55:21.020Z
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

  • src/mongo/db/modules/eloq/data_substrate
🔇 Additional comments (1)
src/mongo/db/modules/eloq/data_substrate (1)

1-1: Verify that the new submodule commit aligns with the PR objective of notifying checkpoint scan workers when raising concurrency.

The data_substrate submodule reference has been updated to commit 02b3b202788cabafe38c89adedfa63cd4234a493 in the upstream tx_service repository. Please confirm that this commit introduces the intended checkpoint scan worker notification functionality and that it does not introduce any regressions to the build configuration options (EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, STATISTICS) referenced in the data_substrate build system.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant