Skip to content

Fix build#229

Merged
lokax merged 2 commits intoeloqdata:mainfrom
lokax:hash-part-scan
Nov 3, 2025
Merged

Fix build#229
lokax merged 2 commits intoeloqdata:mainfrom
lokax:hash-part-scan

Conversation

@lokax
Copy link
Copy Markdown
Collaborator

@lokax lokax commented Oct 9, 2025

Summary by CodeRabbit

  • Refactor

    • Replaced an internal scanner implementation with a more specialized variant; public interfaces, behavior, and user-visible outcomes remain unchanged.
  • Chores

    • Updated internal submodule references; no changes to functionality, outputs, performance expectations, or required user actions.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 9, 2025

Walkthrough

Replaced the concrete scanner type returned by CreateRangeCcmScanner to txservice::HashParitionCcScanner<MongoKey, txservice::RangeRecord>; updated store_handler and tx_service submodule pointers. No signature, call-site, control-flow, or behavioral changes detected. (≤50 words)

Changes

Cohort / File(s) Summary
Scanner type substitution
src/mongo/db/modules/eloq/src/base/eloq_catalog_factory.cpp
Replaced returned scanner implementation from txservice::TemplateCcScanner<MongoKey, txservice::RangeRecord> to txservice::HashParitionCcScanner<MongoKey, txservice::RangeRecord> in CreateRangeCcmScanner; interface and parameters unchanged.
Submodule pointer updates
src/mongo/db/modules/eloq/store_handler/*, src/mongo/db/modules/eloq/tx_service/*
Updated store_handler and tx_service submodule commit pointers to newer commits; no code-level changes in this diff.

Sequence Diagram(s)

(Skipped — change is a type substitution without control-flow or interaction changes.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • xiexiaoy
  • thweetkomputer
  • liunyl

Poem

I nibble code beneath the log,
A hashed hop replaces the bog.
Quiet swap, no panic, no clatter,
New scanner hums — the bytes still matter.
Rabbit winks and carries on, happy as ever. 🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title “Fix build” is overly generic and does not specify the main change of replacing the TemplateCcScanner with the HashPartitionCcScanner in CreateRangeCcmScanner, so it lacks clarity for reviewers and history. Please revise the title to clearly summarize the key change, for example “Replace TemplateCcScanner with HashPartitionCcScanner in CreateRangeCcmScanner to fix build.”
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d234f2 and 1b304fd.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/tx_service (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/mongo/db/modules/eloq/tx_service

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd24035 and 88dd481.

📒 Files selected for processing (3)
  • src/mongo/db/modules/eloq/src/base/eloq_catalog_factory.cpp (1 hunks)
  • src/mongo/db/modules/eloq/store_handler (1 hunks)
  • src/mongo/db/modules/eloq/tx_service (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/mongo/db/modules/eloq/src/base/eloq_catalog_factory.cpp

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b115564 and 7d234f2.

📒 Files selected for processing (2)
  • src/mongo/db/modules/eloq/store_handler (1 hunks)
  • src/mongo/db/modules/eloq/tx_service (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/mongo/db/modules/eloq/tx_service

@@ -1 +1 @@
Subproject commit a3fdbbc866c98b4e70a02aac31a17f408d45d15a
Subproject commit 48a5685ac196eefb73c0b78b51cf1d32a67d5f02
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

❓ Verification inconclusive

Please confirm the submodule commit exists.

Before merging, make sure commit 48a5685ac196eefb73c0b78b51cf1d32a67d5f02 is present in the store_handler remote so the build doesn’t break when cloning.


🏁 Script executed:

#!/bin/bash
# Verify the submodule commit is reachable from its remote
cd src/mongo/db/modules/eloq/store_handler
git fetch --all --tags
git cat-file -t 48a5685ac196eefb73c0b78b51cf1d32a67d5f02

Length of output: 347


Submodule commit missing from remote
Commit 48a5685ac196eefb73c0b78b51cf1d32a67d5f02 isn’t present in the eloqdoc remote. Push that commit or update the submodule pointer to a valid, existing commit before merging.

@lokax lokax force-pushed the hash-part-scan branch 2 times, most recently from e7f041d to c5ec55c Compare October 21, 2025 04:02
Copy link
Copy Markdown
Collaborator

@yi-xmu yi-xmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lokax lokax removed the trigger-ci label Nov 3, 2025
@lokax lokax merged commit 31a3dd2 into eloqdata:main Nov 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants