Closed
Conversation
added 2 commits
July 4, 2020 21:49
elliotchance
reviewed
Jul 4, 2020
orderedmap.go
Outdated
| } | ||
| } | ||
|
|
||
| type Item [2]interface{} |
Owner
There was a problem hiding this comment.
These should not be part of the public API and you will need to provide tests with your code for it to be accepted. Also, please use go fmt.
added 2 commits
July 5, 2020 03:58
elliotchance
reviewed
Jul 4, 2020
orderedmap_test.go
Outdated
| m := orderedmap.NewOrderedMap() | ||
| m.Set(1, 1) | ||
| b, err := json.Marshal(m) | ||
| result := bytes.Equal([]byte(`[1,1]`), b) && nil == err |
Owner
There was a problem hiding this comment.
This is a very opinionated way to serialize that I don't think is suitable for general use. If I remember correctly, I did not include JSON support in orderedmap because serialization is ambiguous (since maps aren't always ordered).
If you need to serialize in this specific format you should create an alias type. I cannot accept this patch, sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is