Add support for dynamic S3 configs per uploader #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case definition.s3_config/0 is not defined it will use ExAws.Config.Defaults.defaults(:s3) which was the default option already
6440208 to
8332546
Compare
Member
|
Hi Erick, thanks for your contribution. What is your use case for the change? |
Author
I'm building a tool to upload files to S3 where every user has their own S3 credentials, also at work in some projects we have to deal with more than one S3 credentials, I think this will give flexibility to the package, also it's backwards compatible because it uses default function to get credentials from |
Author
|
Any chance this can be reviewed again? I'm willing to make any changes that are required :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case definition.s3_config/0 is not defined it will use
ExAws.Config.Defaults.defaults(:s3) which was the default option
already