Skip to content

ELE-957 remove env from report summary #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IDoneShaveIt merged 1 commit into from
May 28, 2023
Merged

ELE-957 remove env from report summary #901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion elementary/monitor/data_monitoring/report/data_monitoring_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ def send_test_results_summary(
include_description=include_description,
filter=self.filter.get_filter(),
days_back=days_back,
env=self.config.env,
),
)
else:
Expand Down
16 changes: 3 additions & 13 deletions elementary/monitor/data_monitoring/report/slack_report_summary_message_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@ def __init__(self) -> None:
def get_slack_message(
self,
test_results: List[TestResultSummarySchema],
env: str,
days_back: int,
bucket_website_url: Optional[str] = None,
filter: SelectorFilterSchema = SelectorFilterSchema(),
include_description: bool = False,
) -> SlackMessageSchema:
self._add_title_to_slack_alert(env=env)
self._add_title_to_slack_alert()
self._add_preview_to_slack_alert(
test_results,
days_back=days_back,
Expand All @@ -35,18 +34,9 @@ def get_slack_message(
)
return super().get_slack_message()

def _add_title_to_slack_alert(
self,
env: str,
):
env_text = (
":construction: Development"
if env == "dev"
else ":large_green_circle: Production"
)

def _add_title_to_slack_alert(self):
title_blocks = [
self.create_header_block(f":mag: Monitoring summary ({env_text})"),
self.create_header_block(":mag: Monitoring summary"),
self.create_divider_block(),
]
self._add_always_displayed_blocks(title_blocks)
Expand Down