Skip to content

Ele 801 support dbt 15 with dbtslimrunner#898

Merged
haritamar merged 2 commits intomasterfrom
ele-801-support-dbt-15-with-dbtslimrunner
May 26, 2023
Merged

Ele 801 support dbt 15 with dbtslimrunner#898
haritamar merged 2 commits intomasterfrom
ele-801-support-dbt-15-with-dbtslimrunner

Conversation

@haritamar
Copy link
Copy Markdown
Collaborator

No description provided.

@linear
Copy link
Copy Markdown

linear bot commented May 26, 2023

ELE-801 Support dbt 1.5 with DbtSlimRunner

Describe the problem
The SaaS is limited to dbt 1.4.1 because newer versions breaks the DbtSlimRunner (which is the class we use to query data - we use it because we have shared code with elementary repo, snd we need to use dbt which is slow without the slim runner)

@github-actions
Copy link
Copy Markdown
Contributor

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.


DEFAULT_VARS: Union[str, Dict[str, Any]]
if dbt_version >= version.parse("1.5.0"):
DEFAULT_VARS = {}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comment below.

@haritamar haritamar merged commit c9052b9 into master May 26, 2023
@haritamar haritamar deleted the ele-801-support-dbt-15-with-dbtslimrunner branch May 26, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants