ELE-890 workaround for redshift run operation regression - update alerts#880
Merged
IDoneShaveIt merged 4 commits intomasterfrom May 17, 2023
Merged
Conversation
ELE-890 Workaround for redshift run-operation update or insert regression
Describe the problem |
Contributor
|
👋 @IDoneShaveIt |
IDoneShaveIt
commented
May 16, 2023
| {{ elementary.edr_cast_as_timestamp('detected_at') }} >= {{ get_alerts_time_limit() }} | ||
| {% endset %} | ||
| {% do elementary.run_query(update_sent_alerts_query) %} | ||
| {% if execute %} |
Contributor
Author
There was a problem hiding this comment.
wrapped the current macro with if execute
IDoneShaveIt
commented
May 16, 2023
| {{ elementary.edr_cast_as_timestamp('detected_at') }} >= {{ get_alerts_time_limit() }} | ||
| {% endset %} | ||
| {% do elementary.run_query(update_skipped_alerts_query) %} | ||
| {% if execute %} |
Contributor
Author
There was a problem hiding this comment.
wrapped the current macro with if execute
Maayan-s
reviewed
May 17, 2023
| @@ -35,9 +35,13 @@ def test_update_sent_alerts( | |||
| calls_args = mock_subprocess_run.call_args_list | |||
Contributor
There was a problem hiding this comment.
@IDoneShaveIt
We don't actually test that the status was updated. No?
Contributor
Author
There was a problem hiding this comment.
Will add a GitHub action for that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a bug with dbt-redshift 1.5.0 and above, we can't update tables using dbt run-operation.
In this PR I am replacing the use of dbt run-operation to update our alerts status, with dbt run (models).