Modified owners validator to accept dict#847
Merged
IDoneShaveIt merged 3 commits intoelementary-data:masterfrom May 8, 2023
Merged
Modified owners validator to accept dict#847IDoneShaveIt merged 3 commits intoelementary-data:masterfrom
IDoneShaveIt merged 3 commits intoelementary-data:masterfrom
Conversation
IDoneShaveIt
reviewed
May 7, 2023
Contributor
IDoneShaveIt
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Left some small comments 🙂
elementary/utils/schema.py
Outdated
| return var | ||
| elif isinstance(var, str): | ||
| loaded_var = try_load_json(var) | ||
| if type(loaded_var) is dict: |
Contributor
There was a problem hiding this comment.
Suggested change
| if type(loaded_var) is dict: | |
| if isinstance(loaded_var, dict): |
Match the rest of the method type checking 🙂
elementary/utils/schema.py
Outdated
Comment on lines
+28
to
+29
| loaded_var = json.dumps(loaded_var) | ||
| return loaded_var |
Contributor
There was a problem hiding this comment.
Suggested change
| loaded_var = json.dumps(loaded_var) | |
| return loaded_var | |
| loaded_var = [json.dumps(loaded_var)] |
elementary/utils/schema.py
Outdated
| @staticmethod | ||
| def _load_var_to_list(var: Union[str, list]) -> list: | ||
| if not var: | ||
| if not var & type(var) != dict: |
Contributor
There was a problem hiding this comment.
Suggested change
| if not var & type(var) != dict: | |
| if not var: |
I don't think this one should be changed.
Currently we support Union[str, list] so if someone is passing a dict it should be OK to fail 🙂.
IDoneShaveIt
approved these changes
May 8, 2023
Contributor
IDoneShaveIt
left a comment
There was a problem hiding this comment.
Looking good!
Thank you for the contribution 💪🏻 💪🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #827
Modified
load_ownersvalidator to accept and return dict. This would prevent report failure.