Fix for ELE-699, None default for --group-by

[dimoschi]

To address issue #816 I've set the default value of --group-by option to None, since later on when the Config is instantiated, the self.slack_group_alerts_by gets alert as the last non-null value.

elementary/elementary/config/config.py

Lines 111 to 115 in 2bc0204

	self.slack_group_alerts_by = self._first_not_none(
	slack_group_alerts_by,
	slack_config.get("group_alerts_by"),
	GroupingType.BY_ALERT.value,
	)

[RoiTabach]

@dimoschi does it now work for you in the config that caused the original issue?
I ran the automation on it anyway.

[dimoschi]

@dimoschi does it now work for you in the config that caused the original issue? I ran the automation on it anyway.

Yes, it works perfectly fine with the config. FYI the config is the following:

slack:
  token: "definitely-not-a-token"
  channel_name: "data-ops"
  group_alerts_by: "table"
  alerts_config:
        alert_fields: ["table", "column", "result_message", "test_parameters", "test_query", "test_results_sample", "description","subscribers"]

and the slack post was the following:

[dimoschi]

Tests failed though 😞

[RoiTabach]

Copied the changes to this PR
#823
In order for the automation to be able to run.

[dimoschi]

@RoiTabach I guess it was because the Pr comes from a forked repo? FYI, I wasn't able to push a new branch, that's why I forked it.

Also, if you can help me setup testing suite, I'm willing to write tests.

[RoiTabach]

@dimoschi it's merged

[RoiTabach]

(@dimoschi Sending you a Slack message in the elementary community slack space)