ELE-673 slack summary remove attention required section#811
ELE-673 slack summary remove attention required section#811IDoneShaveIt merged 3 commits intomasterfrom
Conversation
ELE-673 Slack summary | Remove the "action required" section
We want to do this after getting some feedback from customers. The users we talked to don't use this section and some even find it noisy. The alerts are those who should get people attention therefore it make more sense that they will do the tagging and notify users. The summary is meant to provide a summary of the report and not call to action. |
|
👋 @IDoneShaveIt |
| assert "The amount of results exceeded Slack" in attachments_as_string | ||
|
|
||
|
|
||
| def test_owners_tags_and_subscribers_of_passed_tests_are_filtered_out( |
There was a problem hiding this comment.
This test is no longer relevant because we removed the tags / owners / subscribers from the summary
| # Within attachments limitation | ||
| message_builder = SlackReportSummaryMessageBuilder() | ||
| passed_tests_from_fixture = [x for x in test_results_summary if x.status == "pass"] | ||
| message_builder._add_preview_to_slack_alert(passed_tests_from_fixture) |
There was a problem hiding this comment.
Not needed for the test
| formatted_tags = [ | ||
| tag if tag.startswith(TAG_PREFIX) else f"{TAG_PREFIX}{tag}" | ||
| for tag in test.tags | ||
| def _add_preview_to_slack_alert( |
There was a problem hiding this comment.
No new code, just moved sections from the title to the preview
RoiTabach
left a comment
There was a problem hiding this comment.
Small docs question, otherwise go for merge
Removed the attention required section from the report summary message.
Reformatted the alert structure to make it look good without it.